add Test and fix to Issue 48647 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
============================================
+ Coverage 88.11% 88.11% +<.01%
- Complexity 1216 1218 +2
============================================
Files 158 158
Lines 3903 3904 +1
Branches 422 425 +3
============================================
+ Hits 3439 3440 +1
+ Misses 309 308 -1
- Partials 155 156 +1
Continue to review full report at Codecov.
|
uhafner
requested changes
Apr 3, 2019
| @@ -705,6 +705,32 @@ void shouldDetectKeywordsInRegexCaseInsensitive() { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * Update regular expresion to detect logging prefixes like 17:4>. | |||
There was a problem hiding this comment.
typo: expression
is there a JavaDoc warning because of the 17:4>? Maybe you need to wrap that part in a pre tag.
|
Why does src/main/java/edu/hm/hafner/util/TreeString.java impact my PR? |
uhafner
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-48647
when log lines start with a prefix, e.g. "17:4>", it will be removed by regular expression.