Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make unit test compatible with Jenkins 2.307+ #68

Merged
merged 2 commits into from
Oct 1, 2021
Merged

make unit test compatible with Jenkins 2.307+ #68

merged 2 commits into from
Oct 1, 2021

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Sep 30, 2021 •
edited
Loading

unit test fails starting in Jenkins 2.307 due to terminology changes in jenkinsci/jenkins#5425

cc @MRamonLeon @jglick

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

jglick
jglick reviewed Sep 30, 2021
View reviewed changes
src/test/java/hudson/tasks/AntTest.java Outdated Show resolved Hide resolved
src/test/java/hudson/tasks/AntTest.java Outdated Show resolved Hide resolved
@car-roll car-roll requested a review from jglick September 30, 2021 22:19
@jglick jglick merged commit a0ecfdf into jenkinsci:master Oct 1, 2021
@jglick jglick added the tests label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@rsandell rsandell rsandell approved these changes

@MRamonLeon MRamonLeon MRamonLeon approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@car-roll @jglick @rsandell @MRamonLeon