Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jclouds from 2.5.0 to 2.6.0 #567

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented Nov 27, 2024

Reverting #447, since 2.6.0 contains the fix for JCLOUDS-1620.

jclouds 2.6.0 requires Guice 7.0.0, which is above the version delivered by core (6.0.0), but so far I have found no issue ignoring the upper bounds error and continuing to deliver Guice 6.0.0. Guice 6.0.0 supports both javax and jakarta imports, while 7.0.0 drops support for javax, so 6.0.0 makes more sense for Jenkins. Unfortunately this required adding a few temporary workarounds to the POM file.

Testing done

mvn clean verify, including MinioIntegrationTest

I would appreciate if someone could do a manual test run with an AWS account, since I believe CI unfortunately is not enough.

@basil basil added dependencies java Pull requests that update Java code labels Nov 27, 2024
@basil basil requested a review from a team as a code owner November 27, 2024 23:17
@basil
Copy link
Member Author

basil commented Nov 28, 2024

Tested manually by creating a Pipeline job that uploaded an artifact to S3. Verified that the artifact was correctly uploaded and showed up in my S3 bucket. Also verified in the Script Console that loading com.google.gson.Gson from the Artifact Manager on S3 plugin class loader loaded the class from the GSON API plugin's GSON JAR, as before #447, with Jenkins.instance.pluginManager.getPlugin('artifact-manager-s3').classLoader.loadClass('com.google.gson.Gson').protectionDomain.codeSource.

@basil basil merged commit 1907f9b into jenkinsci:master Nov 28, 2024
17 checks passed
@basil basil deleted the jclouds branch November 28, 2024 17:23
basil added a commit to basil/plugin-compat-tester that referenced this pull request Nov 29, 2024
basil added a commit to jenkinsci/plugin-compat-tester that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant