Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt icon path removal from weekly 2.333 #186

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

NotMyFault
Copy link
Member

Fix legacy icon removal in weekly 2.333 and adapt the changes of matrix-auth 3.0.1, which contains the updated in-house icons.

Fixes JENKINS-67707

Fix legacy icon removal in weekly 2.333 and adapt the changes of matrix-auth 3.0.1, which contains the fixed icons.
@NotMyFault NotMyFault changed the title fix: Fixes JENKINS-67707 Adapt icon path removal from weekly 2.333 Feb 1, 2022
@timja timja added the bug label Feb 2, 2022
@timja timja merged commit 872b197 into jenkinsci:master Feb 2, 2022
@NotMyFault NotMyFault deleted the fix/master/fix-broken-icons branch February 2, 2022 09:14
@bcerati
Copy link

bcerati commented Feb 2, 2022

Thanks @NotMyFault for this fix.

Do you know when it'll be released?

@timja
Copy link
Member

timja commented Feb 2, 2022

release failed here:
https://github.com/jenkinsci/azure-ad-plugin/runs/5033254115?check_suite_focus=true

++ mvn -B -ntp -Dset.changelist -Dexpression=project.version -q -DforceStdout help:evaluate
Error: on='[ERROR] Make sure `git status -s` is empty before using -Dset.changelist: [package-lock.json] (use -Dignore.dirt to make this nonfatal) -> [Help 1]

this file is getting modified

package-lock.json

@NotMyFault
Copy link
Member Author

Artifactory already contains 190.v872b1977148a 🤔

@timja timja mentioned this pull request Feb 2, 2022
@timja
Copy link
Member

timja commented Feb 2, 2022

190.v872b1977148a

Weird it shouldn't, fyi @jglick, a weird one

The build fix is #187

@jglick
Copy link
Member

jglick commented Feb 2, 2022

Artifactory already contains 190.v872b1977148a

Do not know offhand how that could have happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants