Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous user matrix permissions and token authentication #196

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

AdrianFarmadin
Copy link
Contributor

@AdrianFarmadin AdrianFarmadin commented Apr 19, 2022

  • correct entity type for "anonymous" user
  • update config.jelly to match "Matrix Authorization Strategy Plugin
    " https://github.com/jenkinsci/matrix-auth-plugin
  • fix for permission matching in token authorization. The token authorization in Jenkins is implemented as basic authentication with email as username and token as password. The matrix has to save user emails to match the users correctly. In UI will be no difference as the email is automatically resolved to user name in "checkName" API call.
  • group authority should be objectId

Fixes #193
Fixes #194

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the bug label Apr 19, 2022
@timja timja enabled auto-merge (squash) April 19, 2022 08:31
@timja timja merged commit 70a6d52 into jenkinsci:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User permissions are not granted for API calls It is not possible to set permissions for "Anonymous Users"
2 participants