Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed unused html, moved html for better caching and remove d… #265

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

schulmak
Copy link
Contributor

Moved HTML which were just used by one credential type to the folder for better caching.
Reduced duplicate code and moved html which used by more than one credential type to /webapp. For the caching I would like to have them in the "src/main/resources" but I dont know how to do it without duplicate code. If you know how to do it would be nice if you could share it.
Removed src/main/webapp/help-msiPort.html since I could not find where it was used.
Removed the link from "src/main/webapp/help-subscriptionId.html" since it doesnt work anymore. Do you know a alternative link?
Renamed the file help-clientId.html in AzureImdsCredentials to help-clientIdImds.html since help-clientId.html is also in AzureCredentials.

Testing done

Build the plugin locally and opened the help boxes.

image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the documentation A PR that adds to documentation - used by Release Drafter label Oct 14, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you know how to do it would be nice if you could share it.

not aware, I would normally duplicate if its simple or do as you have done for more complex cases

@timja timja merged commit 27ad3b6 into jenkinsci:master Oct 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A PR that adds to documentation - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants