Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate availability type to use descriptor #586

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

timja
Copy link
Member

@timja timja commented Nov 20, 2024

Refactoring to cleanup code in preparation for VMSS support.

For users that have an availability set configured and use JCasC they will need to make a minor change to their configuration:

Before:

availabilityType:
  availabilitySet: "vm-agents"

After:

  availabilityType:
    availabilitySet:
      name: "vm-agents"

I've removed the fluent builders around this area as they are a pain to maintain and JCasC is a lot better, its unlikely they are used.

Testing done

Ensured that VMs are still spawning properly

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja enabled auto-merge (squash) November 20, 2024 23:20
@timja timja merged commit 7c08d4b into jenkinsci:master Nov 20, 2024
16 of 17 checks passed
@timja timja deleted the vmss branch November 20, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant