Add support for storage account RBAC only access #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Dec 1, 2024
| @@ -223,6 +223,38 @@ public String getGalleryResourceGroup() { | |||
|
|
|||
| private static final int GEN_STORAGE_ACCOUNT_UID_LENGTH = 22; | |||
|
|
|||
| private static final String VALIDATE_DEPLOYMENT_TEMPLATE_MESSAGE = "Verify configuration:\n\t{0}{1}{2}{3}" | |||
There was a problem hiding this comment.
moved as method was too long for checkstyle
timja
commented
Dec 1, 2024
| @@ -321,7 +353,7 @@ public String getGalleryResourceGroup() { | |||
| // If disabled, will not attempt to verify or use | |||
| private boolean templateDisabled; | |||
|
|
|||
| private String templateStatusDetails; | |||
| private transient String templateStatusDetails; | |||
There was a problem hiding this comment.
was showing up in jcasc exports
timja
commented
Dec 1, 2024
| @@ -1454,6 +1496,10 @@ public ListBoxModel doFillNsgNameItems( | |||
|
|
|||
| try { | |||
| AzureResourceManager azureClient = AzureResourceManagerCache.get(azureCredentialsId); | |||
| if (azureClient == null) { | |||
| return model; | |||
There was a problem hiding this comment.
azure credentials plugin upgrade introduced a checkfornull annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downstream of jenkinsci/azure-credentials-plugin#271
Fixes #478
This only appears to affect Windows VMs or VMs with an unmanaged disk
Testing done
Created both a template that uses a storage account with key authentication and RBAC only
Submitter checklist