Remove unused commons-validator dependency #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commons-validator dependency was added in the 1.9.1 release as part of 468a595, though there seems to have been no references to validator classes in any history of the repository. It was not includeed in the 1.9 release or any prior releases. The commons-validator dependency was added to the master branch after the 1.9.1 release as part of 5ca8ab7. There are no references to validator classes in the current source code. Removing commons-validator reduces the plugin from over 1MB to less than 60KB. Comparisons are listed below: -rw-rw-r--. 1 mwaite mwaite 54015 Oct 25 2021 ../badge-1.9.hpi -rw-rw-r--. 1 mwaite mwaite 1135545 Jan 12 2022 ../badge-1.9.1.hpi -rw-rw-r--. 1 mwaite mwaite 56150 May 4 07:35 target/badge.hpi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused commons-validator dependency
The commons-validator dependency was added in the 1.9.1 release as part of 468a595, though there seems to have been no references to validator classes in any history of the repository. It was not includeed in the 1.9 release or any prior releases.
The commons-validator dependency was added to the master branch after the 1.9.1 release as part of 5ca8ab7. There are no references to validator classes in the current source code.
Removing commons-validator reduces the plugin from over 1MB to less than 60KB. Comparisons are listed below:
Testing done
Automated tests pass. Will combine with a minimum Jenkins version update and with the Jenkins design library pull request and test interactively to confirm no surprises. The Jenkins design library pull request is:
Submitter checklist