Add bitbucket webhook build cause #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Could you please fix the merge conflicts? :) |
|
anton-kyrylenko are you still looking into this? if not a i can fork an rebase on top of this PR |
6 tasks
|
@lifeofguenter, low effort rebase at #585 if this can speed this along. |
nfalco79
reviewed
Nov 28, 2024
| private String payload; | ||
|
|
||
| public WebhookCause(String payload) { | ||
| this.payload = payload; |
There was a problem hiding this comment.
the entire payload it's too much (maybe it's not safe neither to expose)
Store only the type of webhook event so in the cause you will see something like "pr::created event"
nfalco79
reviewed
Nov 28, 2024
| } | ||
|
|
||
| public String getShortDescription() { | ||
| return "Bitbucket Webhook Cause"; |
There was a problem hiding this comment.
Use message from property file like: Messages.WebhookCause_shortDescription(eventType);
So it can be translated
|
The plugin https://github.com/jenkinsci/bitbucket-plugin already provide the same functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to get the bitbucket webhook cause payload.