Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout over ssh #821

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix checkout over ssh #821

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7329c29
use checkoutCredentialsId if available
MartinHelwig Mar 4, 2024
57bc3eb
Merge branch 'master' into bugfix/checkout-over-ssh
MartinHelwig Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketGitSCMBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*/
package com.cloudbees.jenkins.plugins.bitbucket;

import com.cloudbees.jenkins.plugins.bitbucket.BitbucketSCMSource.DescriptorImpl;
import com.cloudbees.jenkins.plugins.bitbucket.api.BitbucketHref;
import com.cloudbees.jenkins.plugins.bitbucket.api.BitbucketRepository;
import com.cloudbees.jenkins.plugins.bitbucket.api.BitbucketRepositoryProtocol;
Expand Down Expand Up @@ -159,7 +160,7 @@
StandardCredentials credentials = BitbucketCredentials.lookupCredentials(
scmSource.getServerUrl(),
scmSource.getOwner(),
credentialsId,
DescriptorImpl.SAME.equals(scmSource.getCheckoutCredentialsId()) ? credentialsId : scmSource.getCheckoutCredentialsId(),

Check warning on line 163 in src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketGitSCMBuilder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 163 is only partially covered, one branch is missing

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
BitbucketSCMSource.getCheckoutCredentialsId
Loading
should be avoided because it has been deprecated.

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
BitbucketSCMSource.getCheckoutCredentialsId
Loading
should be avoided because it has been deprecated.
StandardCredentials.class
);

Expand Down