[JENKINS-73038] Adapt plugin to allow user with Overall/Manage to configure global settings #846
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...va/com/cloudbees/jenkins/plugins/bitbucket/endpoints/BitbucketEndpointConfigurationTest.java
Fixed
Show fixed
Hide fixed
...va/com/cloudbees/jenkins/plugins/bitbucket/endpoints/BitbucketEndpointConfigurationTest.java
Fixed
Show fixed
Hide fixed
| MockAuthorizationStrategy mockStrategy = new MockAuthorizationStrategy(); | ||
| mockStrategy.grant(Jenkins.MANAGE).onRoot().to("admin"); | ||
| j.jenkins.setAuthorizationStrategy(mockStrategy); | ||
| try (ACLContext context = ACL.as(User.get("admin"))) { |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
| @@ -5,7 +5,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.80</version> | |||
| <version>4.81</version> | |||
There was a problem hiding this comment.
Isn't it risking conflict with the automatic dependency PR #844 ?
There was a problem hiding this comment.
if so i will resolve it
| @@ -30,6 +30,7 @@ | |||
| <gitHubRepo>jenkinsci/bitbucket-branch-source-plugin</gitHubRepo> | |||
| <jenkins.version>2.401.3</jenkins.version> | |||
| <hpi.compatibleSinceVersion>2.0</hpi.compatibleSinceVersion> | |||
| <useBeta>true</useBeta> <!-- Jenkins.MANAGE --> | |||
There was a problem hiding this comment.
Is it supposed to stay or was it to test ?
There was a problem hiding this comment.
It is required until an agreement can be had that its safe to take the Overall/Manage permission feature out of beta
There was a problem hiding this comment.
OK, I read badly this conf, I thought it was forcing the plugin in beta mode -_-
My bad, sorry.
There was a problem hiding this comment.
no worries, i've also started JENKINS-73089 to address moving the Overall/Manage permission out of beta status
|
@LyroStedman / @basil / @rsandell could i get an additional review when you have a minute? |
|
@LyroStedman / @basil if you happy with the PR can you please merge it at your convenience? |
Adapt plugin to allow user with Overall/Manage to configure global settings under
Manage Jenkins-->SystemJenkins Issue -> https://issues.jenkins.io/browse/JENKINS-73038
Your checklist for this pull request