Move some implementations classes under impl packages to be clear that are implementations and not APIs #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t are implementations and not APIs Melt build status notification test classes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -42,8 +42,7 @@ | |||
| * @throws IOException if there was a communication error during notification. | |||
| * @throws InterruptedException if interrupted during notification. | |||
| */ | |||
| public abstract void notify(@CheckForNull String repoOwner, @CheckForNull String repoName, String hash, String content) | |||
| throws IOException, InterruptedException; | |||
| void notifyComment(@CheckForNull String repoOwner, @CheckForNull String repoName, String hash, String content) throws IOException, InterruptedException; | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
| @@ -42,8 +42,7 @@ | |||
| * @throws IOException if there was a communication error during notification. | |||
| * @throws InterruptedException if interrupted during notification. | |||
| */ | |||
| public abstract void notify(@CheckForNull String repoOwner, @CheckForNull String repoName, String hash, String content) | |||
| throws IOException, InterruptedException; | |||
| void notifyComment(@CheckForNull String repoOwner, @CheckForNull String repoName, String hash, String content) throws IOException, InterruptedException; | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
|
|
||
| @ParameterizedTest(name = "checkURL {0} against Bitbucket Server") | ||
| @MethodSource("buildServerURLsProvider") | ||
| void test_checkURL_for_Bitbucket_server(String jenkinsURL, String expectedExceptionMsg, @NonNull JenkinsRule r) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
|
|
||
| @ParameterizedTest(name = "checkURL {0} against Bitbucket Cloud") | ||
| @MethodSource("buildCloudURLsProvider") | ||
| void test_checkURL_for_Bitbucket_cloud(String jenkinsURL, String expectedExceptionMsg, @NonNull JenkinsRule r) { |
Check notice
Code scanning / CodeQL
Useless parameter Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Melt build status notification test classes