Extract event anonymous inner classes from webhook processor. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } catch (AbstractMethodError e) { | ||
| type.getProcessor().process(body, instanceType); | ||
| hookProcessor.process(body, instanceType); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
src/main/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/ServerPushEvent.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/PullRequestHookProcessorTest.java
Fixed
Show fixed
Hide fixed
nfalco79
force-pushed
the
feature/webhook_cleanup_test_case
branch
4 times, most recently
from
95d67e8 to
59f5bf4
Compare
src/test/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/PullRequestHookProcessorTest.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/com/cloudbees/jenkins/plugins/bitbucket/hooks/PullRequestHookProcessorTest.java
Dismissed
Show dismissed
Hide dismissed
nfalco79
force-pushed
the
feature/webhook_cleanup_test_case
branch
2 times, most recently
from
7008d51 to
1c99e54
Compare
Move test to JUnit5 and add processor unit test Add unit test for hook processor when process pull request. Consider to add other events for tag, new commit and so on
nfalco79
force-pushed
the
feature/webhook_cleanup_test_case
branch
from
1c99e54 to
1c02a35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move test to JUnit5 and add processor unit test
Add unit test for hook processor when process pull request.
Consider to add other events for tag, new commit and so on