Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75160] NO_PROXY configuration seems to be ignored #972

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

nfalco79
Copy link
Member

Fix proxy configuration to be used in the Apache client created from the ProxyConfiguration class using only the hostname instead passing the configured serverURL. The NO_PROXY configuration matches only hostname, that means if the given hostname contains also scheme or port match fails.

@nfalco79 nfalco79 marked this pull request as draft January 18, 2025 12:36
@nfalco79 nfalco79 force-pushed the feature/JENKINS-75160 branch from cadaaf8 to 8debdc6 Compare January 18, 2025 13:48
@nfalco79 nfalco79 marked this pull request as ready for review January 18, 2025 13:50
@nfalco79 nfalco79 force-pushed the feature/JENKINS-75160 branch 2 times, most recently from 1c4cd84 to 8bbf2e0 Compare January 18, 2025 14:00
Fix proxy configuration to be used in the Apache client created from the ProxyConfiguration class using only the hostname instead passing the configured serverURL. The NO_PROXY configuration matches only hostname, that means if the given hostname contains also scheme or port match fails.
@nfalco79 nfalco79 force-pushed the feature/JENKINS-75160 branch from 8bbf2e0 to 0ccc00f Compare January 18, 2025 14:02
@nfalco79 nfalco79 merged commit b15a872 into 934.3.x Jan 18, 2025
17 checks passed
@nfalco79 nfalco79 deleted the feature/JENKINS-75160 branch January 18, 2025 14:17
@nfalco79 nfalco79 added the bug label Jan 18, 2025
nfalco79 added a commit that referenced this pull request Jan 18, 2025
Fix proxy configuration to be used in the Apache client created from the ProxyConfiguration class using only the hostname instead passing the configured serverURL. The NO_PROXY configuration matches only hostname, that means if the given hostname contains also scheme or port match fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant