Use email-aliases-plugin to find authors User objects #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i386
commented
Nov 12, 2016
| if (User.getById(author.getId(), false) == null || !((GitSCM) scm).isCreateAccountBasedOnEmail()) { | ||
| UserProperty property = first.getAuthor().getProperty(UserProperty.class); | ||
| if (property != null && property.getConfiguredAddress() != null) { | ||
| for (User user : User.getAll()) { |
There was a problem hiding this comment.
Linear search feels wrong here for a few reasons:
- log(n) time to search here should not be added to the build time of the first run. Probably should offload this to a different thread?
- I suspect it is expensive to load all Users like this but I cant be sure.
Advice wanted :)
| final Job<?, ?> job = build.getParent(); | ||
| User author = first.getAuthor(); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Interesting changes from this point onward.
|
@daniel-beck @imeredith @vivek it would be great to get a review here. |
i386
force-pushed
the
topic/email-alias
branch
from
48429ce to
21f3f9c
Compare
i386
commented
Nov 13, 2016
|
|
||
| @Nullable | ||
| private User findUserByEmailAlias(@Nonnull String email) { | ||
| for (User user : User.getAll()) { |
There was a problem hiding this comment.
I realise this is bad and I feel bad. I am considering creating a Search API in the email-aliases plugin to do this efficiently for multiple callers.
i386
force-pushed
the
topic/email-alias
branch
from
21f3f9c to
9fa1978
Compare
|
I know this is kinda moot now, but i always used https://wiki.jenkins.io/display/JENKINS/Additional+Identities+Plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users often have multiple email addresses that they use to commit changes in Git. It is not always the case that a users committer email and Jenkins email will be the same.
email-aliases-pluginallows a User to defined a set of email addresses that are related to their identity. When we run autofavorite we should use these addresses to help more accurately discover the user to assign the favorite to.This PR depends on the initial commit of the
email-aliases-pluginso it should be reviewed in conjunction with this PR. See https://github.com/i386/email-aliases-plugin/pull/1.