Adds auto-favoriting exclusion for workflow libraries #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froque
force-pushed
the
support_workflow_libraries
branch
from
9a6c4f2 to
a8bc2c4
Compare
|
Jenkins seems to be ignoring my changes to Jenkinsfile https://ci.jenkins.io/job/Plugins/job/blueocean-autofavorite-plugin/job/PR-123/2/console |
Without testing if a remote URL is a match for the buildData it might log an error when testing a specific commit against the wrong git repository: Unexpected error when retrieving changeset hudson.plugins.git.GitException: Error: git whatchanged --no-abbrev ... Should fix JENKINS-43400. Fixing the previous behavior leads to auto-favoriting the author of the last commit for the workflow library for all builds that contains the workflow library. pipeline-groovy-lib contains duplicate code from deprecated plugin workflow-cps-global-lib-plugin. Could not add support for both plugins due the java package being the same.
froque
force-pushed
the
support_workflow_libraries
branch
from
a8bc2c4 to
13d80c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without testing if a remote URL is a match for the buildData it might log an error when testing a specific commit against the wrong git repository: Unexpected error when retrieving changeset
hudson.plugins.git.GitException: Error: git whatchanged --no-abbrev ... Should fix JENKINS-43400 Autofavorite broken on remote agents.
Fixing the previous behavior leads to auto-favoriting the author of the last commit for the workflow library for all builds that contains the workflow library.
pipeline-groovy-lib contains duplicate code from deprecated plugin workflow-cps-global-lib-plugin. Could not add support for both plugins due the java package being the same.
Testing done
Submitter checklist