Experiment/selenium logs

acceptance-tests/nightwatch.conf.js

@@ -3,7 +3,7 @@ module.exports = (function (settings) {
     var url = require('url');
     var launchUrl;
     var netaddr = require('network-address');
-  
+
     if (process.env.LAUNCH_URL) {
         //
         // This allows you to run the tests against a Jenkins instance of
@@ -29,7 +29,7 @@ module.exports = (function (settings) {
 
         launchUrl = fs.readFileSync(jenkins_url_file, 'utf8');
     }
-    
+
     // Replace localhost addresses with the actual IP, allowing it
     // to work inside a docker container running on the host.
     launchUrl = launchUrl.replace('localhost', netaddr());
@@ -46,7 +46,7 @@ module.exports = (function (settings) {
 
     console.log('Jenkins running at: ' + settings.test_settings.default.launch_url);
     console.log("    NOTE:");
-    console.log("        Selenium and the browser (Firefox) are running in a docker");
+    console.log("        Selenium and the browser are running in a docker");
     console.log("        container that also has VNC. This allows you to connect if");
     console.log("        you'd like to look at the browser while the tests run.");
     console.log("        Simple run:");
@@ -59,6 +59,6 @@ module.exports = (function (settings) {
     if (fs.existsSync('target/.selenium_server_provided')) {
         settings.selenium.start_process = false;
     }
-    
+
     return settings;
 })(require('./src/main/nightwatch.json'));

acceptance-tests/runner/runtime/src/test/java/utils/DevRunner.java

@@ -31,7 +31,7 @@
  * @author <a href="mailto:tom.fennelly@gmail.com">tom.fennelly@gmail.com</a>
  */
 public class DevRunner extends BOJUnitTest {
-    
+
     @Test
     public void runAndStayRunning() throws Exception {
         System.out.println("");
@@ -50,7 +50,7 @@ public void runAndStayRunning() throws Exception {
         System.out.println("    See http://nightwatchjs.org/");
         System.out.println("");
         System.out.println("    NOTE:");
-        System.out.println("        Selenium and the browser (Firefox) are running in a docker");
+        System.out.println("        Selenium and the browser are running in a docker");
         System.out.println("        container that also has VNC. This allows you to connect if");
         System.out.println("        you'd like to look at the browser while the tests run.");
         System.out.println("        Simple run:");
@@ -59,7 +59,7 @@ public void runAndStayRunning() throws Exception {
         System.out.println("------------------------------------------------------------------------------------");
         System.out.println("");
         System.out.println("ctrl-c to exit...");
-        
+
         while(true) {
             Thread.sleep(1000);
         }

acceptance-tests/runner/scripts/start-selenium.sh

@@ -6,7 +6,7 @@ $SCRIPT_DIR/stop-selenium.sh
 echo ""
 echo " Starting Selenium Docker container..."
 echo ""
-docker run -d --name blueo-selenium -p 15900:5900 -p 4444:4444 -e no_proxy=localhost selenium/standalone-firefox-debug:2.53.0 > /dev/null
+docker run -d --name blueo-selenium -p 15900:5900 -p 4444:4444 -e no_proxy=localhost selenium/standalone-chrome-debug:3.6.0-bromine > /dev/null
 
 # Output the containers bridge network IP to file
 SELENIUM_IP=`docker inspect -f '{{ .NetworkSettings.IPAddress }}' blueo-selenium`
@@ -15,7 +15,7 @@ echo $SELENIUM_IP > ./target/.selenium_ip
 
 echo ""
 echo "**************************************************************"
-echo "**** Docker container with Selenium, Firefox and VNC running."
+echo "**** Docker container with Selenium, browser and VNC running."
 echo "****   Selenium server listening on $SELENIUM_IP:4444"
 echo "****   "
 echo "****   To connect and view with VNC, run:"

acceptance-tests/src/main/java/io/blueocean/ath/ATHJUnitRunner.java

@@ -18,6 +18,8 @@
 import org.openqa.selenium.OutputType;
 import org.openqa.selenium.TakesScreenshot;
 import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.logging.LogEntries;
+import org.openqa.selenium.logging.LogEntry;
 import org.openqa.selenium.remote.ScreenshotException;
 
 import java.io.File;
@@ -75,8 +77,10 @@ public void evaluate() throws Throwable {
 
                 try {
                     next.evaluate();
+                    outputConsoleLogs();
                 } catch (Exception e) {
                     writeScreenShotCause(e, test, method);
+                    outputConsoleLogs();
                     throw e;
                 }
 
@@ -114,7 +118,16 @@ private void writeScreenShotCause(Throwable t, Object test, FrameworkMethod meth
             FileUtils.copyFile(scrFile, file);
             logger.info("Wrote screenshot to " + file.getAbsolutePath());
         }
-     }
+    }
+
+    private void outputConsoleLogs() {
+        logger.info("browser console output below:");
+        WebDriver driver = injector.getInstance(WebDriver.class);
+        LogEntries logs = driver.manage().logs().get("browser");
+        for (LogEntry entry : logs) {
+            LogEntryLogger.recordLogEntry(entry);
+        }
+    }
 
 
     @Override
@@ -174,4 +187,5 @@ public synchronized Throwable fillInStackTrace() {
             return this;
         }
     }
+
 }

acceptance-tests/src/main/java/io/blueocean/ath/AthModule.java

@@ -19,7 +19,10 @@
 import io.blueocean.ath.pages.blue.RunDetailsArtifactsPage;
 import io.blueocean.ath.pages.blue.RunDetailsPipelinePage;
 import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.logging.LogType;
+import org.openqa.selenium.logging.LoggingPreferences;
 import org.openqa.selenium.remote.Augmenter;
+import org.openqa.selenium.remote.CapabilityType;
 import org.openqa.selenium.remote.DesiredCapabilities;
 import org.openqa.selenium.remote.RemoteWebDriver;
 
@@ -29,12 +32,16 @@
 import java.nio.file.Files;
 import java.nio.file.Paths;
 import java.util.Properties;
+import java.util.logging.Level;
 
 public class AthModule extends AbstractModule {
     @Override
     protected void configure() {
 
-        DesiredCapabilities capability = DesiredCapabilities.firefox();
+        DesiredCapabilities capability = DesiredCapabilities.chrome();
+        LoggingPreferences logPrefs = new LoggingPreferences();
+        logPrefs.enable(LogType.BROWSER, Level.ALL);
+        capability.setCapability(CapabilityType.LOGGING_PREFS, logPrefs);
 
         try {
             WebDriver driver = new RemoteWebDriver(new URL("http://localhost:4444/wd/hub"), capability);

acceptance-tests/src/main/java/io/blueocean/ath/LogEntryLogger.java

@@ -0,0 +1,57 @@
+package io.blueocean.ath;
+
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.log4j.Logger;
+import org.openqa.selenium.logging.LogEntry;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * Writes a Selenium LogEntry to log4j
+ * @author cliffmeyers
+ */
+class LogEntryLogger {
+    private static final Logger logger = Logger.getLogger(LogEntryLogger.class);
+    private static final ObjectMapper jsonMapper = new ObjectMapper();
+    private static final TypeReference<HashMap<String, Object>> typeRef = new TypeReference<HashMap<String, Object>>() {};
+
+    static void recordLogEntry(LogEntry entry) {
+        if (!logger.isInfoEnabled() || isSuperfluousLogEntry(entry)) {
+            return;
+        }
+
+        String time;
+        String level;
+        String text;
+
+        try {
+            // handle messages written by @jenkins-cd/js-logging
+            Map<String, Object> messageJson = jsonMapper.readValue(entry.getMessage(), typeRef);
+            Map<String, Object> message = (Map<String, Object>) messageJson.get("message");
+            time = String.valueOf(message.get("timestamp"));
+            level = String.valueOf(message.get("level"));
+            text = String.valueOf(message.get("text"));
+        } catch (IOException e) {
+            // handle messages written natively by console.error|warn|log|debug
+            time = String.valueOf(entry.getTimestamp());
+            level = String.valueOf(entry.getLevel());
+            text = entry.getMessage();
+        }
+
+        logger.info(String.format("%s - %s - %s", time, level, text));
+    }
+
+    // special handling to suppress some repetitive logging messages that are not helpful
+    private static final String MESSAGE_JS_LOGGING = "@jenkins-cd/logging is explained";
+    private static final String MESSAGE_CHROME_CONSOLE = "Chrome displays console errors";
+    private static final String MESSAGE_PASSWORD_INSECURE = "page includes a password or credit card input";
+
+    static boolean isSuperfluousLogEntry(LogEntry entry) {
+        String message = entry.getMessage();
+        return message.contains(MESSAGE_JS_LOGGING) || message.contains(MESSAGE_CHROME_CONSOLE) ||
+            message.contains(MESSAGE_PASSWORD_INSECURE);
+    }
+}

acceptance-tests/src/main/java/io/blueocean/ath/WaitUtil.java

@@ -6,6 +6,7 @@
 import org.openqa.selenium.NoSuchElementException;
 import org.openqa.selenium.NotFoundException;
 import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.WebDriverException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.ui.ExpectedConditions;
 import org.openqa.selenium.support.ui.FluentWait;
@@ -18,7 +19,7 @@
 @Singleton
 public class WaitUtil {
     private Logger logger = Logger.getLogger(WaitUtil.class);
-
+    private static final int RETRY_COUNT = 2;
 
     private WebDriver driver;
 
@@ -82,4 +83,28 @@ public <T> Function<WebDriver, Integer> orVisible(Function<WebDriver, WebElement
         };
     }
 
+    /**
+     * Click the element specified by the locator.
+     * Will retry click for 'element not clickable' exceptions
+     * @param by
+     */
+    public void click(By by) {
+        for (int i = 0; i < RETRY_COUNT + 1; i++) {
+            try {
+                until(ExpectedConditions.elementToBeClickable(by)).click();
+                if (i > 0) {
+                    logger.info(String.format("retry click successful for %s", by.toString()));
+                }
+                return;
+            } catch (WebDriverException ex) {
+                if (ex.getMessage().contains("is not clickable at point")) {
+                    logger.warn(String.format("%s not clickable: will retry click", by.toString()));
+                    logger.debug("exception: " + ex.getMessage());
+                } else {
+                    throw ex;
+                }
+            }
+        }
+    }
+
 }

acceptance-tests/src/main/java/io/blueocean/ath/pages/blue/EditorPage.java

@@ -55,7 +55,7 @@ public void simplePipeline(String newBranch) {
         wait.until(By.cssSelector("button.btn-primary.add")).click();
         wait.until(By.xpath("//*[text()='Print Message']")).click();
         wait.until(By.cssSelector("input.TextInput-control")).sendKeys("hi there");
-        wait.until(By.xpath("(//span[@class='back-from-sheet'])[2]")).click();
+        wait.click(By.xpath("(//a[@class='back-from-sheet'])[2]"));
         wait.until(By.xpath("//*[text()='Save']")).click();
         wait.until(By.cssSelector("textarea[placeholder=\"What changed?\"]")).sendKeys("Simple pipeline");
         if(!Strings.isNullOrEmpty(newBranch)) {

acceptance-tests/src/main/java/io/blueocean/ath/pages/blue/GitCreationPage.java

@@ -42,7 +42,7 @@ public GitCreationPage(WebDriver driver) {
     }
 
     public GitCreationPage clickGitCreationOption() {
-        wait.until(By.xpath("//span[text()='Git']")).click();
+        wait.until(By.cssSelector(".scm-provider-list .git-creation")).click();
         logger.info("Selected git creation");
         return this;
     }

acceptance-tests/src/main/java/io/blueocean/ath/pages/blue/GithubCreationPage.java

@@ -5,7 +5,6 @@
 import io.blueocean.ath.api.classic.ClassicJobApi;
 import org.apache.log4j.Logger;
 import org.openqa.selenium.By;
-import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.support.FindBy;
@@ -35,14 +34,11 @@ public GithubCreationPage(WebDriver driver) {
     @FindBy(css = ".button-connect")
     public WebElement connectButton;
 
-    @FindBy(css = ".button-single-repo")
-    public WebElement singlePipelineBtn;
-
     @FindBy(css = ".repo-list input")
     public WebElement pipelineSearchInput;
 
     @FindBy(css = ".button-create")
-    public WebElement createBtn;
+    public WebElement createPipelineButton;
 
     @Inject
     @BaseUrl
@@ -111,18 +107,26 @@ public void selectPipelineToCreate(String pipeline){
         logger.info("Selected pipeline to create");
     }
 
+    public void clickCreatePipelineButton() {
+        wait.until(ExpectedConditions.elementToBeClickable(createPipelineButton)).click();
+    }
+
     public By emptyRepositoryCreateButton = By.cssSelector(".jenkins-pipeline-create-missing-jenkinsfile > div > button");
 
     public void createPipeline(String apikey, String org, String pipeline) throws IOException {
         createPipeline(apikey, org, pipeline, false);
     }
     public void createPipeline(String apiKey, String org, String pipeline, boolean createJenkinsFile) throws IOException {
-        beginCreationFlow(org);
+        beginCreationFlow(pipeline);
         completeCreationFlow(apiKey, org, pipeline, createJenkinsFile);
     }
 
-    public void beginCreationFlow(String org) throws IOException {
-        jobApi.deletePipeline(org);
+    /**
+     * @param jobName name of job to be created
+     * @throws IOException
+     */
+    public void beginCreationFlow(String jobName) throws IOException {
+        jobApi.deletePipeline(jobName);
         navigateToCreation();
         selectGithubCreation();
     }
@@ -139,8 +143,7 @@ public void completeCreationFlow(String apiKey, String org, String pipeline, boo
         logger.info("Select a repo to create");
 
         selectPipelineToCreate(pipeline);
-
-        wait.until(createBtn).click();
+        clickCreatePipelineButton();
 
         if(createJenkinsFile) {
             wait.until(ExpectedConditions.urlContains("pipeline-editor"), 30000);

acceptance-tests/src/main/js/page_objects/blueocean/bluePipelineActivity.js

@@ -97,7 +97,7 @@ module.exports.commands = [{
         this.waitForRunVisible(pipeline, runId);
         const resultRowSelector = activityRowSelector(pipeline, runId);
         this.waitForElementVisible(`${resultRowSelector} .failure`);
-    },    
+    },
 
     /**
      * Wait for a specific run to appear in the activity table as unstable
@@ -133,19 +133,19 @@ module.exports.commands = [{
      * Inspect that result screen runs, shows a stage graph, and completes.
      */
     assertStageGraphShows: function() {
-      //check results look kosher:
-      this.waitForElementVisible('.progress-spinner.running');                           
-      this.waitForElementVisible('.BasicHeader--running');
-
-      this.waitForElementVisible('.pipeline-node-selected');                  
-      this.waitForElementVisible('.download-log-button');                  
-      this.waitForElementVisible('.pipeline-selection-highlight');                    
-      this.waitForElementVisible('.pipeline-connector');     
-      this.waitForElementVisible('.pipeline-node-hittarget');     
-      this.waitForElementVisible('.BasicHeader--success');  
+        //check results look kosher:
+        this.waitForElementVisible('.progress-spinner.running');
+        this.waitForElementVisible('.BasicHeader--running');
 
+        this.waitForElementVisible('.pipeline-node-selected');
+        this.waitForElementVisible('.download-log-button');
+        this.waitForElementVisible('.pipeline-selection-highlight');
+        // in Chrome, 'Visible' seems to fail but 'Present' works ok
+        this.waitForElementPresent('.pipeline-connector');
+        this.waitForElementPresent('.pipeline-node-hittarget');
+        this.waitForElementVisible('.BasicHeader--success');
     },
-    
+
     /**
     * Click css selector of a specific tab
     * @param tab {string} the tab we want to select

acceptance-tests/src/main/js/page_objects/blueocean/bluePipelineRunDetail.js

@@ -434,9 +434,8 @@ module.exports.commands = [{
    */
   clickReRunButton: function () {
     var self = this;
-    const browser = this.api;
-    self.waitForElementVisible('.replay-button');
-    self.click('.replay-button');
+    self.waitForElementVisible('.ResultPageHeader-run .replay-button');
+    self.click('.ResultPageHeader-run .replay-button');
     return self;
   }