Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promoted Builds to the managed set #3171

Closed
MarkEWaite opened this issue May 5, 2024 · 2 comments · Fixed by #3502
Closed

Add Promoted Builds to the managed set #3171

MarkEWaite opened this issue May 5, 2024 · 2 comments · Fixed by #3502
Assignees
Labels
enhancement New feature or request

Comments

@MarkEWaite
Copy link
Contributor

MarkEWaite commented May 5, 2024

What feature do you want to see added?

Add the promoted builds plugin to the managed set of plugins because it has over 10000 installations and is an optional dependency of several popular plugins that are already included in the plugin BOM:

Those two optional dependencies were updated in releases of the respective plugins that were verified with Jenkins 2.457.

It is also a test dependency of a plugin in the plugin BOM:

It is also an optional dependency of another "top 250 plugin":

It is also a test dependency of "top 250 plugins":

Upstream changes

Will probably also require inclusion of the Job DSL plugin in the managed set. I failed in my attempt to add Job DSL plugin in:

Are you interested in contributing this feature?

Failed in my attempt to add the promoted builds plugin to the managed set in:

@MarkEWaite MarkEWaite added the enhancement New feature or request label May 5, 2024
MarkEWaite added a commit to MarkEWaite/parameterized-trigger-plugin that referenced this issue May 6, 2024
jenkinsci/bom#3171 describes the issue.  The
promoted builds version needs to be kept the same in the git plugin
and in the paramaterized trigger plugin.  If they are not the same,
then tests will fail in the plugin bill of materials.
@basil basil changed the title Add promoted builds plugin to managed set Add Promoted Builds to managed set Jun 4, 2024
@basil
Copy link
Member

basil commented Aug 27, 2024

Will probably also require inclusion of the Job DSL plugin in the managed set. I failed in my attempt to add Job DSL plugin

@MarkEWaite Job DSL is now included, so this ticket should be unblocked.

@MarkEWaite
Copy link
Contributor Author

Will probably also require inclusion of the Job DSL plugin in the managed set. I failed in my attempt to add Job DSL plugin

@MarkEWaite Job DSL is now included, so this ticket should be unblocked.

Thanks. I've started an attempt to add promoted builds to the bom as well using the job-dsl PR as a starting point.

@MarkEWaite MarkEWaite self-assigned this Aug 27, 2024
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Aug 27, 2024
@MarkEWaite MarkEWaite changed the title Add Promoted Builds to managed set Add Promoted Builds to the managed set Aug 28, 2024
MarkEWaite added a commit to MarkEWaite/maven-plugin that referenced this issue Aug 28, 2024
https://github.com/jenkinsci/bom/releases/tag/3307.v2769886db_63b_
now manages the promoted builds plugin version.  This pom can no longer
needs to specify the version of promoted builds plugin.

jenkinsci/bom#3171 describes some of the
reasons why that benefits this plugin and why it benefits the plugin
BOM maintainers.
olamy pushed a commit to jenkinsci/maven-plugin that referenced this issue Sep 5, 2024
* Bump org.jenkins-ci.plugins:promoted-builds

Bumps [org.jenkins-ci.plugins:promoted-builds](https://github.com/jenkinsci/promoted-builds-plugin) from 892.vd6219fc0a_efb to 957.vf5b_cee587563.
- [Release notes](https://github.com/jenkinsci/promoted-builds-plugin/releases)
- [Changelog](https://github.com/jenkinsci/promoted-builds-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jenkinsci/promoted-builds-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:promoted-builds
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Modernize to Jenkins 2.440.3

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

Co-authored-by: Moderne <team@moderne.io>

* Use parent pom 4.87

* Rely on promoted-builds from bom 3307.v2769886db_63b_

https://github.com/jenkinsci/bom/releases/tag/3307.v2769886db_63b_
now manages the promoted builds plugin version.  This pom can no longer
needs to specify the version of promoted builds plugin.

jenkinsci/bom#3171 describes some of the
reasons why that benefits this plugin and why it benefits the plugin
BOM maintainers.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Steve Hill <sghill.code@outlook.com>
Co-authored-by: Moderne <team@moderne.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants