Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Custom Notification Context SCM Behaviour to managed set #4021

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Add GitHub Custom Notification Context SCM Behaviour to managed set #4021

merged 1 commit into from
Nov 24, 2024

Conversation

darinpope
Copy link
Contributor

Add GitHub Custom Notification Context SCM Behaviour to managed set

Testing done

  • LINE=weekly PLUGINS=github-scm-trait-notification-context bash local-test.sh
  • LINE=2.479.x PLUGINS=github-scm-trait-notification-context bash local-test.sh
  • LINE=2.462.x PLUGINS=github-scm-trait-notification-context bash local-test.sh
  • LINE=2.452.x PLUGINS=github-scm-trait-notification-context bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@darinpope darinpope added the full-test Test all LTS lines in this PR and do not halt upon first error. label Nov 24, 2024
@darinpope
Copy link
Contributor Author

Merging even though there was a failure with gitlab 2.452.x:

GitLabConnectionConfigSSLTest.startJetty:143 » IO Failed to bind to 0.0.0.0/0.0.0.0:38571

All the other gitlab LINEs were fine.

@darinpope darinpope marked this pull request as ready for review November 24, 2024 20:33
@darinpope darinpope requested a review from a team as a code owner November 24, 2024 20:33
@darinpope darinpope merged commit f13b54d into jenkinsci:master Nov 24, 2024
897 of 900 checks passed
@darinpope darinpope deleted the add-github-scm branch November 24, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@darinpope