Testing jenkins-test-harness#910

[strangelookingnerd]

jenkinsci/jenkins-test-harness#910

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[strangelookingnerd]

@timja Sorry to bother but I assumed that the incremental from jenkinsci/jenkins-test-harness#910 would be pulled here. But this seems not to be the case. What am I missing?

[timja]

@timja Sorry to bother but I assumed that the incremental from jenkinsci/jenkins-test-harness#910 would be pulled here. But this seems not to be the case. What am I missing?

I think you need to set it in https://github.com/jenkinsci/bom/blob/master/pct.sh#L20 (outside of that if block)

[timja]

@Vlatombe has done something in this area recently I think

[timja]

Looks like it is being re-overridden:

https://ci.jenkins.io/job/Tools/job/bom/job/PR-4324/2/pipeline-console/log?nodeId=4823

o.j.t.t.m.ExternalMavenRunner#run: Running mvn -B -V -e -ntp -pl :ant -Dmaven.test.failure.ignore=true -Dsurefire.rerunFailingTestsCount=1 -DforkCount=.75C -Djenkins-test-harness.version=2390.v2f27c3de6c38 -Dsurefire.excludesFile=/home/jenkins/agent/workspace/Tools_bom_PR-4324/excludes.txt -DoverrideWar=/home/jenkins/agent/workspace/Tools_bom_PR-4324/target/megawar-weekly.war -Djenkins.version=2.494 -DuseUpperBounds=true -DoverrideVersions=jakarta.servlet:jakarta.servlet-api:5.0.0 -DupperBoundsExcludes=org.junit.jupiter:junit-jupiter-api hpi:resolve-test-dependencies hpi:test-hpl hpi:test-runtime surefire:test -Djenkins-test-harness.version=2244.2247.ve6b_a_8191b_95f 

I think you need to create a PR to here: https://github.com/jenkinsci/plugin-compat-tester/blob/master/src/main/java/org/jenkins/tools/test/hook/JenkinsTestHarnessHook.java and then update PCT version in an incremental.