Skip to content

Commit

Permalink
Merge pull request #178 from res0nance/override-todo
Browse files Browse the repository at this point in the history
Fix some override TODOs
  • Loading branch information
bitwiseman authored Feb 13, 2020
2 parents e3ef78c + abdbf5a commit 170e771
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,34 +79,25 @@ public String getDisplayName() {
}

/**
* Needed if it wants SCMNavigator implementations are categorized in Jenkins 2.x.
*
* TODO: Override when the baseline is upgraded to 2.x
*
* @return A string with the Item description.
* {@inheritDoc}
*/
@Override
public String getDescription() {
return delegate.getDescription();
}

/**
* Needed if it wants SCMNavigator implementations are categorized in Jenkins 2.x.
*
* TODO: Override when the baseline is upgraded to 2.x
*
* @return A string it represents a ItemCategory identifier.
* {@inheritDoc}
*/
@Override
public String getCategoryId() {
return delegate.getCategoryId();
}

/**
* Needed if it wants SCMNavigator implementations are categorized in Jenkins 2.x.
*
* TODO: Override when the baseline is upgraded to 2.x
*
* @return A string it represents a URL pattern to get the Item icon in different sizes.
* {@inheritDoc}
*/
@Override
public String getIconFilePathPattern() {
return delegate.getIconFilePathPattern();
}
Expand Down
6 changes: 5 additions & 1 deletion src/main/java/jenkins/branch/MultiBranchProject.java
Original file line number Diff line number Diff line change
Expand Up @@ -2369,7 +2369,11 @@ public final XmlFile getStateFile() {
*/
@Extension
public static class CopyItemVeto extends ItemListener {
//@Override // TODO once Jenkins 2.51+ which has JENKINS-34691 merged

/**
* {@inheritDoc}
*/
@Override
public void onCheckCopy(Item item, ItemGroup parent) throws Failure {
if (item.getParent() instanceof MultiBranchProject) {
throw new Failure(Messages.MultiBranchProject_CopyItemVeto_reason());
Expand Down

0 comments on commit 170e771

Please sign in to comment.