[JENKINS-54992] Do not override pronoun on projects only on their scan #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abayer
approved these changes
Apr 17, 2019
This issue shows that changing the pronoun on a project in in order to make some actions by the project more clear is actually problematic. As reasonable fix, this change makes the indexing use the source pronoun(s) while reverting the projects to using their original pronouns.
bitwiseman
force-pushed
the
JENKINS-54992
branch
from
0726a7d
to
b050869
Compare
stephenc
approved these changes
Apr 17, 2019
rsandell
approved these changes
Apr 17, 2019
|
@bitwiseman You do now. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue shows that changing the pronoun on a project in
in order to make some actions by the project more clear is
actually problematic.
As reasonable fix, this change makes
the indexing use the source pronoun(s) while reverting the
projects to using their original pronouns.
This PR came from discussions around
jenkinsci/github-branch-source-plugin#195
After this change the Multibranch Pipeline looks like this:
A github organization folder looks like this:
