[JENKINS-49729] Add some css to job and run pages for dead branches #151
Conversation
Also had to tweak the dependencies a bit since the introduction of git 4.0.0-rc broke hpi:run
rsandell
requested review from
bitwiseman,
abayer,
dwnusbaum,
car-roll,
joseblas and
jglick
|
Added @jglick since I overwrote his git 4 change. |
| /** | ||
| * An action that puts some css on job and run pages for jobs representing {@link Branch.Dead}. | ||
| */ | ||
| public class DeadBranchIndicatorAction implements Action { |
There was a problem hiding this comment.
FWIW there is hudson.model.InvisibleAction for this use case, although no harm in keeping it how it is now.
| } | ||
| h1.job-index-headline { | ||
| text-decoration: line-through; | ||
| color: silver; |
There was a problem hiding this comment.
Before/after screenshots would be nice to see what it looks like.
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" | ||
| xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt"> | ||
| <!--TODO build-caption i.e. the links to the builds on the job page doesn't take effect--> | ||
| <style type="text/css"> |
There was a problem hiding this comment.
How does jobMain.jelly get loaded? I would've thought it would need to be named action.jelly to be picked up here, but I am probably missing something.
There was a problem hiding this comment.
action.jellyis for rendering in the left sidebarjobMain.jellyis for rendering in the center main page on a job, like the last junit results, warnings etc.summary.jellyis for rendering in the center main page of a build like the junit or warnings summary etc.
They are standard action views across both AbstractBuilds and WorkflowRuns.
There was a problem hiding this comment.
There is also floatingBox.jelly which renders the trend graphs on the right hand side of a build page.
The build summary worked for me when I tried at first because there was an old summary.jelly in the cache from an earlier attempt. Also use the actual disabled ball color instead of hardcoded silver. And InvisibleAction instead of standard Action.
|
The build failures seems to be because problems with the windows agents getting terminated. |
|
Maybe I'm reading the build logs wrong, so gonna try to revert the pom changes to see if that helps. |
|
I think you were just running into infra issues, I've see this error on various repositories (I would link the relevant INFRA ticket but am getting a 502 on issues.jenkins-ci.org...):
Best option I know of in these cases is just to close/reopen the PR to get a fresh build until it passes. |
|
Well the revert helped (or the rerun) so I'll leave it as is unless someone else reviews and finds something :) |
Also had to tweak the dependencies a bit since the introduction of
git 4.0.0-rc broke hpi:run
Before
Job Page
Except for the "This job is currently disabled" message which was still there before
After
Job Page
Build Page