Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-61438] Demonstration of IAE from Stapler #185

Merged
merged 5 commits into from
Aug 28, 2020
Merged

[JENKINS-61438] Demonstration of IAE from Stapler #185

merged 5 commits into from
Aug 28, 2020

Conversation

nfalco79
Copy link
Member

The new test case fails with

java.lang.IllegalArgumentException: Unable to convert to class java.lang.Object
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:738)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:478)
	at org.kohsuke.stapler.RequestImpl.injectSetters(RequestImpl.java:834)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:784)
	at org.kohsuke.stapler.RequestImpl.access$200(RequestImpl.java:83)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:678)
Caused: java.lang.IllegalArgumentException: Failed to instantiate class hudson.model.ParameterDefinition from {"name":"CHOOSE","choices":"a\nb","description":"choose one","stapler-class":"hudson.model.ChoiceParameterDefinition","$class":"hudson.model.ChoiceParameterDefinition"}
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:681)

@jglick Now I will try to use the incremental build of stapler to prove the fix is valid

@nfalco79 nfalco79 mentioned this pull request Mar 11, 2020
Merged
@jglick jglick self-requested a review March 12, 2020 16:18
jglick
jglick reviewed Mar 12, 2020
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@jglick jglick self-requested a review March 12, 2020 16:20
@jglick jglick removed their request for review April 27, 2020 20:34
@jglick
Copy link
Member

jglick commented Jun 11, 2020

For reference: jenkinsci/stapler#181 jenkinsci/stapler#182

@jglick jglick marked this pull request as draft June 11, 2020 17:47
@jglick jglick added the tests label Jun 11, 2020
@jglick jglick changed the title [JENKINS-61438] Demostration for stapler issue 181 [JENKINS-61438] Demonstration of IAE from Stapler Jun 11, 2020
@nfalco79 nfalco79 marked this pull request as ready for review June 15, 2020 14:15
@nfalco79 nfalco79 marked this pull request as draft June 15, 2020 14:15
@nfalco79 nfalco79 marked this pull request as ready for review June 16, 2020 09:24
nfalco79 and others added 2 commits July 7, 2020 15:16
@bitwiseman bitwiseman merged commit e4acacf into jenkinsci:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfalco79 @jglick @bitwiseman