Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test core versions based on pom #229

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Test core versions based on pom #229

merged 1 commit into from
Nov 10, 2020

Conversation

timja
Copy link
Member

@timja timja commented Nov 7, 2020

Preparation for #228

@dwnusbaum dwnusbaum mentioned this pull request Nov 9, 2020
Merged
dwnusbaum
dwnusbaum approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I filed #232 to get a CI build using the updated Jenkinsfile.

fqueiruga
fqueiruga reviewed Nov 10, 2020
View reviewed changes
Copy link

@fqueiruga fqueiruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this does :D. Does this mean that the baseline is increased?

@timja
Copy link
Member Author

timja commented Nov 10, 2020

I don't know what this does :D. Does this mean that the baseline is increased?

the plugin was configured to run CI against newer baselines, the problem is I'm updating the baseline to above these versions which makes CI break.

but because i'm not a 'trusted' contributor to this repository (write access), my changes are ignored so I can't make the build green in my other PR without this change

@dwnusbaum dwnusbaum merged commit 420a2fb into jenkinsci:master Nov 10, 2020
@dwnusbaum dwnusbaum mentioned this pull request Nov 10, 2020
Merged
@timja timja deleted the patch-1 branch November 10, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqueiruga fqueiruga fqueiruga approved these changes

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timja @dwnusbaum @fqueiruga