-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump baseline, POM, BOM, etc. #353
Conversation
@@ -1 +0,0 @@ | |||
**/target/*.hpi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who knows f466945
With a minor update to use parent pom 4.59 and bom version 1981.v17df70e84a_a_1 this would also supersede #356 and #360. I see one test failure
That failure is visible on Debian testing and on Ubuntu 22.04. |
One step at a time. I wanted to file a PR which covered the transition to Java 11. Individual updates can be applied on their own merits. (Some, like @jtnord, object to applying |
Sorry, where is this test failure? I cannot see it in this PR. If you mean after applying further BOM updates, then let us address that there. |
After further investigation, it looks like the test failure requires a newer parent pom (4.59) but does not require any change to the BOM version. This passes with parent pom 4.53 as proposed:
This fails with parent pom 4.59 as the only change from this pull request
Handling that test failure can certainly wait until after this pull request is merged. Updating from parent pom 4.50 to 4.53 is already a step in the right direction. |
Supersedes #352, #351, & #314.