BuildStrategies implementation need to know the current job #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
commented
May 10, 2023
| @NonNull TaskListener listener) { | ||
| return isAutomaticBuild(source, head, currRevision, lastBuiltRevision, lastSeenRevision, listener, null); | ||
| } | ||
|
|
||
| public abstract boolean isAutomaticBuild(@NonNull SCMSource source, |
There was a problem hiding this comment.
this pattern of keep adding parameters is getting worst and worst :(
Maybe we could have something such (pseudo code) to avoid breaking backward compat with every new data:
class AutomaticBuild {
SCMHead head;
SCMRevision currRevision;
// all the getters/setters
}
or wait to be 17 here and use record :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy olamy@apache.org
Testing done
Submitter checklist