-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEE-37070] add inline documentation for build strategies #388
base: master
Are you sure you want to change the base?
Conversation
<f:entry title="${%Build strategies}" field="buildStrategies"> | ||
<f:entry title="${%Strategy}" field="strategyId"></f:entry> | ||
<f:hetero-list name="buildStrategies" items="${instance.buildStrategies}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fake f:entry
does not look right. You should not need to resort to tricks to have help for a standard form control. I think the problem here is that the original page used unnecessarily low-level controls. Better to use the higher-level f:repeatableHeteroProperty
which groks databinding and should allow you to simply create a file with the conventional name, help-buildStrategies.html
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -43,7 +43,7 @@ | |||
</j:if> | |||
<j:set var="descriptors" value="${descriptor.buildStrategiesDescriptors(it,sourceDescriptor)}"/> | |||
<j:if test="${!descriptors.isEmpty()}"> | |||
<f:entry title="${%Build strategies}"> | |||
<f:entry title="${%Build strategies}" field="buildStrategies"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, showing
branch-api-plugin/src/main/resources/jenkins/branch/BranchSource/help-buildStrategies.html
Lines 2 to 4 in 09d4261
By default (i.e. when empty), everything except tags will be automatically built whenever discovered or changed. | |
If you add at least one strategy then the defaults will be disabled and only the configured strategies will be | |
applied. |
Might not be possible to use branch-api-plugin/src/main/java/jenkins/branch/BranchSource.java Lines 177 to 178 in 09cb8ea
|
Add inline documentation for Build Strategies
Testing done
Submitter checklist