Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by PR number #491

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Sort by PR number #491

merged 1 commit into from
Oct 29, 2024

Conversation

timja
Copy link
Member

@timja timja commented Oct 28, 2024

Mostly addresses #476 (comment)
It doesn't work for e.g. 10 which is sorted before 2, but this should restore the previous sort order.

Example PRs:
image

Branches layout is fine:
image

FYI @janfaracik

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja requested a review from a team as a code owner October 28, 2024 21:39
@jtnord
Copy link
Member

jtnord commented Oct 28, 2024

I think so. If someone selected a non default display option, this could cause some confusion, but the sort order would be consistent and not depend on the display option

@jtnord jtnord requested a review from a team October 28, 2024 21:54
@jglick jglick merged commit fad0c47 into jenkinsci:master Oct 29, 2024
17 checks passed
@timja timja deleted the sort-by-pr-number branch October 29, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants