[JENKINS-66014] Adding support retryable writes. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable retryable writes settings while adding plugin configuration
rsandell
reviewed
Sep 24, 2021
| @@ -706,7 +721,7 @@ private MongoClient getMongoConnection() { | |||
|
|
|||
| }).applyToServerSettings(builder12 -> { | |||
| }).applyToSocketSettings(builder13 -> builder13.connectTimeout((CONNECT_TIMEOUT), TimeUnit.MILLISECONDS)). | |||
| applyToSslSettings(builder14 -> builder14.enabled(tls)); | |||
| applyToSslSettings(builder14 -> builder14.enabled(tls)).retryWrites(disableRetryWrites); | |||
There was a problem hiding this comment.
This looks so weird. Why is it inverted here and not below?
There was a problem hiding this comment.
Addressed the concern and simplified it
rsandell
reviewed
Sep 24, 2021
| @@ -41,11 +41,14 @@ | |||
| <f:entry title="${%Use TLS connection}"> | |||
| <f:checkbox field="tls" /> | |||
| </f:entry> | |||
| <f:entry title="${%Disable RetryWrites}"> | |||
There was a problem hiding this comment.
This makes it even more confusing.
There was a problem hiding this comment.
Needs a help file and better naming of the field.
There was a problem hiding this comment.
Simplified the change
|
@rsandell Updated the code |
1 similar comment
|
@rsandell Updated the code |
rsandell
approved these changes
Feb 4, 2022
rsandell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with MongoDB 4.2 compatible drivers, retryable writes is enabled by default. However, Amazon DocumentDB does not currently support retryable writes. I am adding a support to enable/disable that setting while using this plugin
Options