Added multi node support for MongoDB #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host setting can now be input as a list of hosts, separated by a comma. For everyone just inputting one host, there is no change in functionality. Made getMongoConnection in MongoDBKnowledgeBase package-private for testing purposes.
rsandell
reviewed
Jun 3, 2022
| hostlist.add(new ServerAddress(host, port)); | ||
| List<ServerAddress> hostlist = new LinkedList<>(); | ||
| for (String h: host.split(",")) { | ||
| hostlist.add(new ServerAddress(h, port)); |
There was a problem hiding this comment.
Some input sanitation seems to be needed here. For example:
Suggested change
| hostlist.add(new ServerAddress(h, port)); | |
| h = StringUtils.trimToNull(h); | |
| if (h != null) { | |
| hostlist.add(new ServerAddress(h, port)); | |
| } |
A future improvement could be to allow each host to have a port specified as well host1:port,hots2:port,...
There was a problem hiding this comment.
Some input sanitation seems to be needed here. For example:
A future improvement could be to allow each host to have a port specified as well
host1:port,hots2:port,...
I concur, that is a good future improvement.
rsandell
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host setting can now be input as a list of hosts, separated
by a comma. For everyone just inputting one host, there is no change
in functionality.
Made getMongoConnection in MongoDBKnowledgeBase package-private for
testing purposes.