Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow customizing the default settings #71

Closed
patrickdepinguin opened this issue Jul 15, 2014 · 5 comments · Fixed by #573
Closed

Feature request: allow customizing the default settings #71

patrickdepinguin opened this issue Jul 15, 2014 · 5 comments · Fixed by #573

Comments

@patrickdepinguin
Copy link
Contributor

patrickdepinguin commented Jul 15, 2014

The plugin has a fixed default configuration, and stores user-made changes in a cookie. This works fine when displaying the build monitor view on a controllable display.
However, when displaying it on a system without keyboard/mouse, like a web kiosk, modifying the configuration so it would be stored in the cookie is problematic.
Being able to set the default configuration in absence of a cookie could cover this scenario.
I currently worked around this by manually editing the javascript files, but this is not very nice.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jan-molak
Copy link
Member

Thanks for your feedback, @patrickdepinguin. That's a good point. If you'd like to raise a pull request I'd be happy to merge it.

One thing to consider though is that it might be simpler to implement something along the lines of what's suggested in #54. Would this solve your problem?

Looking forward to hearing from you!
J

@patrickdepinguin
Copy link
Contributor Author

Yes, using URL parameters as suggested in #54 would solve my problem. In fact, it would be even better since it allows tweaking the build monitor for different screen configurations without requiring cookies.
If you would go forward with implementing #54 then feel free to close this issue. Thanks!

@jan-molak
Copy link
Member

Looks like #189 could cover this scenario.

@patrickdepinguin
Copy link
Contributor Author

Yes looks like it, consider this issue and that pr coupled!

@jan-molak
Copy link
Member

Cool, cheers, will do ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants