Move settings to config page as default #119 #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tcollignon! I'm currently working on addressing #124, #165 and #57 and will review your PR as soon as I'm done with those. Best, |
|
Hi, any news here? |
|
This would be very welcome |
hughsaunders
added a commit
to hughsaunders/jenkins-build-monitor-plugin
that referenced
this pull request
Jul 18, 2019
This commit allows Jenkins users to specify defaults for build monitor views when creating the views from the Jenkins UI. End users can still modify these settings using the widget within build monitor. This is useful because the defaults do not scale to large numbers of builds so if a user is creating a build monitor view that they anticipate will contain a large number of builds they can increase the number of columns and prevent each end user from having to do that individually. This is essentially a rebase of @tcolligon's changes in pr jenkinsci#189 and is related to issue jenkinsci#119.
|
Resolved the conflicts in a new PR: #413 |
hughsaunders
added a commit
to hughsaunders/jenkins-build-monitor-plugin
that referenced
this pull request
Jul 18, 2019
This commit allows Jenkins users to specify defaults for build monitor views when creating the views from the Jenkins UI. End users can still modify these settings using the widget within build monitor. This is useful because the defaults do not scale to large numbers of builds so if a user is creating a build monitor view that they anticipate will contain a large number of builds they can increase the number of columns and prevent each end user from having to do that individually. This is essentially a rebase of @tcolligon's changes in pr jenkinsci#189 and is related to issue jenkinsci#119.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR2 of #119.
This is my first contribution of this plugin, so tell me all the problems with this PR, and I will fix it.
I have try to give tests, but I'm not sure it's ok for you.
Thanks