-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #364 #365
Fix for #364 #365
Conversation
@mawatech if I'm not mistaken the BadgeAction has been moved to a new plugin, so technically there is no need to have a dependency on the groovy-postbuild plugin I suggest you change the dependency in the pom <dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>badge</artifactId>
<version>1.2</version>
</dependency> |
build-monitor-plugin/pom.xml
Outdated
@@ -166,7 +166,7 @@ | |||
<dependency> | |||
<groupId>org.jvnet.hudson.plugins</groupId> | |||
<artifactId>groovy-postbuild</artifactId> | |||
<version>2.3.1</version> | |||
<version>2.4</version> | |||
<optional>true</optional> | |||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the suggestion from @dcendents .
This should be replaced with:
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>badge</artifactId>
<version>1.2</version>
<optional>true</optional>
</dependency>
(adding optional=true
to the dcendents's comment)
And the plugin name to test should be also replaced to badge
:
https://github.com/jan-molak/jenkins-build-monitor-plugin/blob/v1.11%2Bbuild.201701152243/build-monitor-plugin/src/main/java/com/smartcodeltd/jenkinsci/plugins/buildmonitor/viewmodel/JobViews.java#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm a maintainer of groovy-postbuild and I caused this problem. Really sorry.
I think this is the best way to fix the problem.
Build-monitor-plugin should depend directly on badge-plugin rather than groovy-postbuild, please update the dependency definition in pom.xml.
Badge plugin (and groovy-postbuild-2.4+) targets Jenkins 2.60.3 and acceptance test may not work correct. (I don't have an appropriate environment and haven't tried it...) |
Looks like the badge-related acceptance tests ( Does this mean that we need to update the Jenkins core version Build Monitor relies on? @mawatech, @ikedam, @dcendents? |
OK, so upgrading to Jenkins 2.x looks like a fairly large piece of work. I'll have a look into that, but can't really promise any timeframes. Any help would be appreciated. |
I’m afraid upgrading the core version takes some more time. @jan-molak I’m thinking of releasing groovy-postbuild-2.4.1 in the following way. Would you comment for this idea?
|
@ikedam - I think you're right. I spent a couple of hours looking into upgrading the jenkins core dependency, but it's not a straightforward process as the maven verifier they now have in place requires upgrading a ton of other dependencies. I'm not that familiar with the internals of the Jan |
I've merged this into my #370 and also implemented backwards compatibility. This PR alone will break compatibility with old Jenkins' using the old Groovy Postbuild plugin. |
Closed by #370 |
This PR should fix issue #364
Used jenkinsci/groovy-postbuild-plugin@4aee649 as reference how to fix it.
Short test on a local Jenkins instance showed no problems.