-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-72581] Replace Prototype.js in the 'Run' button #132
[JENKINS-72581] Replace Prototype.js in the 'Run' button #132
Conversation
https://issues.jenkins.io/browse/JENKINS-72581 describes the failure with Jenkins 2.426.2. Does not fix the "Delete" button. That needs to be replaced with the modern version of delete that will use a modal dialog.
@dalvizu this is another one that I've tested well enough to justify a release. The "Delete" button doesn't work with Jenkins 2.426.2, but that will need to be a different fix. |
Do you have permissions to merge and create a release? I contribute almost no value to this project now, so am fine with you moving unilaterally on any fixes that you're willing to support and maintain. I have minimal time to contribute here and no technical resources beyond an environment I can cut a release from and permissions to do so. I'm happy to continue doing that, if it's valuable, but don't want you to be waiting on things when you can be moving faster. When I started maintaining this plugin, I was a full time Java engineer building CI/CD and using this plugin for our production workflows. I'm now in senior management and don't use this technology in any capacity. |
I don't have those permissions and am not ready to add this plugin to the group of plugins that I maintain. I'm not a user of the plugin. I think that users of the plugin are the preferred maintainers.
Creating a new release is valuable and a great help. I hope the impact on your time is low and I'm very grateful if you are willing to continue doing that. |
@dalvizu does your time allow you to merge this and create a release? I understand if it does not, that's not a problem, but I thought it was worth a check. |
Thanks very much @dalvizu ! |
[JENKINS-72581] Replace Prototype.js in the "Run" button
JENKINS-72581 describes the failure with Jenkins 2.426.2. The "Run" button reports a JavaScript error rather than starting the build. With this change, the build starts as expected. Change was made based on the instructions in the Prototype.js removal blog post.
Does not fix the "Delete" button. That needs to be replaced with the modern version of delete that will use a modal dialog.
Testing done
Interactive testing confirmed that I can duplicate the problem before this change and that after this change, the Run button behaves as expected.
Submitter checklist