Refresh plugin for October 2024 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Mar 29, 2024
.mvn/extensions.xml
Outdated
Comment on lines
1
to
7
| <extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd"> | ||
| <extension> | ||
| <groupId>io.jenkins.tools.incrementals</groupId> | ||
| <artifactId>git-changelist-maven-extension</artifactId> | ||
| <version>1.7</version> | ||
| </extension> | ||
| </extensions> |
There was a problem hiding this comment.
Comment on lines
+1
to
+2
| -Pconsume-incrementals | ||
| -Pmight-produce-incrementals |
There was a problem hiding this comment.
Jenkinsfile
Outdated
Comment on lines
5
to
6
| [platform: 'linux', jdk: 21], | ||
| [platform: 'windows', jdk: 17], |
There was a problem hiding this comment.
pom.xml
Outdated
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>plugin</artifactId> | ||
| <version>4.74</version> | ||
| <version>4.80</version> |
There was a problem hiding this comment.
| <relativePath /> | ||
| </parent> | ||
| <artifactId>build-pipeline-plugin</artifactId> | ||
| <version>2.0.2-SNAPSHOT</version> | ||
| <version>${revision}${changelist}</version> |
There was a problem hiding this comment.
| <licenses> | ||
| <license> | ||
| <name>MIT License</name> | ||
| <url>http://www.opensource.org/licenses/mit-license.php</url> | ||
| <url>https://opensource.org/license/mit/</url> |
There was a problem hiding this comment.
Comment on lines
+23
to
+26
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | ||
| <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection> | ||
| <url>https://github.com/${gitHubRepo}</url> | ||
| <tag>${scmTag}</tag> |
There was a problem hiding this comment.
pom.xml
Outdated
Comment on lines
29
to
32
| <revision>2.0.2</revision> | ||
| <changelist>-SNAPSHOT</changelist> | ||
| <jenkins.version>2.414.3</jenkins.version> | ||
| <gitHubRepo>jenkinsci/${project.artifactId}</gitHubRepo> |
There was a problem hiding this comment.
Comment on lines
+191
to
+192
| <groupId>org.codehaus.gmavenplus</groupId> | ||
| <artifactId>gmavenplus-plugin</artifactId> |
There was a problem hiding this comment.
| @@ -38,6 +38,7 @@ public void init() throws Exception { | |||
| jr.jenkins.rebuildDependencyGraph(); | |||
| } | |||
|
|
|||
| @Ignore | |||
There was a problem hiding this comment.
This whole Selenium-based test suite was failing and excluded by default, except during releases, except for these two tests. Ignoring these two tests like all the others.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #126, updating this plugin to continue building on Java 17/21.
Testing done
mvn clean verifyCloses #134