Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update jQuery filter removal syntax for 3.x compatibility #141

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Oct 23, 2024

Manually tested.

This recent upgrade to jQuery 3.x in #140 breaks the existing functionality in https://github.com/jenkinsci/build-pipeline-plugin/blob/master/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/BuildCardExtension/buildCardTemplate.jelly#L64

Screenshot 2024-10-23 at 3 58 39 PM
[Error] TypeError: content.get(0).style.removeAttr is not a function. (In 'content.get(0).style.removeAttr('filter')', 'content.get(0).style.removeAttr' is undefined)
	_finish (jquery.fancybox-1.3.4.js:580)
	(anonymous function) (jquery.min.js:2:61095)
	c (jquery.min.js:2:25310)
	fireWith (jquery.min.js:2:26055)
	u (jquery.min.js:2:57809)
	(anonymous function) (jquery.min.js:2:62806)
	dt (jquery.min.js:2:57126)

After change, works as expected.
Screenshot 2024-10-23 at 4 00 37 PM

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that and thanks for noticing this.

src/main/webapp/js/jquery.fancybox-1.3.4.js Outdated Show resolved Hide resolved
Co-authored-by: Basil Crow <me@basilcrow.com>
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 0ff593b into jenkinsci:master Oct 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants