Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build user vars plugin: Remove unnecessary utility class, relocated constants to a more generic context #127

Merged

Conversation

fabiodcasilva
Copy link
Contributor

@fabiodcasilva fabiodcasilva commented Apr 14, 2024

Refactor build user vars plugin:

  • Remove unnecessary utility class.
  • Relocated constants to a more generic context class.
  • Add missing tests to UsernameUtils

Submitter checklist

Preview Give feedback

@fabiodcasilva fabiodcasilva requested a review from a team as a code owner April 14, 2024 17:34
@fabiodcasilva
Copy link
Contributor Author

@basil can I kindly ask you for a review?

@fabiodcasilva
Copy link
Contributor Author

@oleg-nenashev can you please review this PR?

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. This looks great!

@fabiodcasilva
Copy link
Contributor Author

Sorry for the late reply. This looks great!

thanks!

@fabiodcasilva fabiodcasilva merged commit 0da9345 into jenkinsci:master Aug 30, 2024
16 checks passed
@fabiodcasilva fabiodcasilva deleted the refactor-build-user-vars branch August 31, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants