Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-40236] Fixed shortname string to match project #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jarrodconnolly
Copy link

Modified the SHORTNAME static string from ClangScanBuildUtils.java to match the project one in build.gradle

It seems "-plugin" was dropped from the name but missed here.

…ildUtils.java to match the project one in build.gradle
@nickbroon
Copy link

👍

@comicfans
Copy link

jenkins also need this to be consist to generate correct resource url, or clang-scanbuild icon png gives 404

@jarrodconnolly
Copy link
Author

Made this pull request quite some time ago, seems a few of us would still love to have it merged. The Hacktoberfest website reminded me to come check how this was doing. I realize it was submitted way outside the timeline but maybe we can get it into the project now that lots of things are being merged?

@jenkinsci/code-reviewers

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field is public static, so it's hard to predict all possible issues. But now the change does not break cases within the plugin itself (and it really fixes the defect).

👍

@oleg-nenashev
Copy link
Member

I am not sure who maintains the plugin now. @rodrigc is it still interesting to you?

@jarrodconnolly
Copy link
Author

Yay its hacktoberfest again! Any chance we can get this merged this year? ;)

Thank you anyone who can help.

@rodrigc

@jarrodconnolly
Copy link
Author

Yay its hacktoberfest again!

Couldn't help it, actually sad to see that I missed popping in last year :(

Have a great year everyone!

@VarshaUN
Copy link

hey is this issue still open? @jarrodconnolly

@jarrodconnolly
Copy link
Author

hey is this issue still open? @jarrodconnolly

I have not used this plugin in a minute. If someone is using it would be great to verify if this is still occurring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants