-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow implementations do initialisation additions #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I do not see specific reason to prohibit overrides. It would be great to have a @CallSuper
annotation, but there is no such annotation in Java
It's also interesting that it possible to call |
@jglick CC according to history you introduced final |
Hi @KostyaSha. I neither do see any specific reason to avoid the override, but since this final statement has been there since 3 years ago and nothing seems to be failing, I would like to have more details about the motivation/concerns before merging anything. |
@fcojfernandez in last 3 years nobody were making any implementations based on folders, since multibranch api become wider used, custom implementations must have ability to do initialisation of their own stuff.
I need to do custom things before multibranch starts. That's why upper hierarchy had no final statements. That's look like @jglick mistakenly locked it. |
But in your custom implementation you could initialise their own stuff in the constructor, since you should create one. (Sorry if I seem picky, but I like having all the details and context to be sure the change makes sense and is safe) |
Move doesn't call constructor, move calls |
|
|
@jglick is there any blocker to make it non-final?
super.init()
is not final but this override blocks ability to make aditional initialisations right after job was moved and has newparent, name
.This change is