Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65161] Remove usage of Digester taken from Jenkins Core #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MRamonLeon
Copy link

@MRamonLeon MRamonLeon commented May 3, 2021

This is a follow up PR for jenkinsci/jenkins#5320 tracked by issues.jenkins.io/browse/JENKINS-65161

We're removing Digester from Jenkins core because it's not used there. This PR adds Digester to this plugin and builds the object to parse xmls safely.

I had to fix some warnings linter were yelling.

No maintainers listed in https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-cmvc.yml

Pinging the contributors: @ndeloof @alanharder
Additional reviewers: @alecharp @olamy @rsandell @car-roll @bitwiseman @jtnord

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MRamonLeon MRamonLeon changed the title [JENKINS-65161] Remove usage of Digester taken from Jenkins Core #5 [JENKINS-65161] Remove usage of Digester taken from Jenkins Core May 3, 2021
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@rsandell
Copy link
Member

rsandell commented May 3, 2021

Though while updating you should probably have taken the few extra seconds to make the digester safe as well.

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must use the safety settings

src/main/java/hudson/plugins/cmvc/util/CmvcRawParser.java Outdated Show resolved Hide resolved
@MRamonLeon MRamonLeon requested review from batmat and alecharp May 4, 2021 10:38
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small question about the transient field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants