-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-65161] Remove usage of Digester taken from Jenkins Core #3
base: master
Are you sure you want to change the base?
Conversation
Though while updating you should probably have taken the few extra seconds to make the digester safe as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we must use the safety settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small question about the transient
field.
This is a follow up PR for jenkinsci/jenkins#5320 tracked by issues.jenkins.io/browse/JENKINS-65161
We're removing Digester from Jenkins core because it's not used there. This PR adds Digester to this plugin and builds the object to parse xmls safely.
I had to fix some warnings linter were yelling.
No maintainers listed in https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-cmvc.yml
Pinging the contributors: @ndeloof @alanharder
Additional reviewers: @alecharp @olamy @rsandell @car-roll @bitwiseman @jtnord