Fix test errors because of change in security classes on new Jenkins core versions #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRamonLeon
requested review from
rsandell,
alecharp,
imod,
olamy,
jtnord,
car-roll and
bitwiseman
jtnord
reviewed
Jul 6, 2021
| @@ -134,8 +134,10 @@ public Config newConfig(@NonNull String id, String name, String comment, String | |||
|
|
|||
| private void setField(String fieldName, String value, Config config) { | |||
| Field field = ReflectionUtils.findField(config.getClass(), fieldName); | |||
| field.setAccessible(true); | |||
| ReflectionUtils.setField(field, config, value); | |||
| if (field != null) { | |||
There was a problem hiding this comment.
if the field is null won't this cause failures later on?
presumably this was trying to set the field to actually accomplish something so failing silently would seem bad.
There was a problem hiding this comment.
The fields set are only name, comment, content which are in the base Config class. So there is no way to not find them. This change is to make spotbugs happy
jtnord
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some acegisecurity classes were still over there. Those fixes were not complete: #124