-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-66708] Prepare removal of sunset icons from core #146
[JENKINS-66708] Prepare removal of sunset icons from core #146
Conversation
c404110
to
e423c33
Compare
e423c33
to
0a42baf
Compare
3885bf9
to
52ce416
Compare
Incorrectly closed. Sorry for that. I'll merge the PR soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no expert on (or fan of) material theme or graphic design and I do acknowledge changing the icon can be disruptive, so I'd rather see a straight .png - .svg conversion; so a scripted lettering. Nevertheless, if changing to a material design, the icon should reflect the utility, not just another "page icon". Given this purpose of the plugin is 1) Configuration 2) File 3) Management, I'd suggest something with the representative icons for each. I cut and pasted a couple material icons and came up with this: It immediately tells me it's a controlled settings file., which is pretty close to "config-file-provide". Thoughts ? Maybe an SVG expert like @NotMyFault Alex can make compliant / and add the appropriate flair consistent w/other icons (ie: combine the Configure System gear and the Security lock)
|
Core has expressed some interest in replacing tango icons with more modern ones from sources like Iconic, font awesome or material while maintaining a color palette striving through its components, e.g. the font color from my screenshot above or the refurbished table design in this week's release. That's why I didn't pull in an icon of these "legacy" sources. |
Hi Alex, What I am saying is the proposed change should simply be from PNG to SVG ( identical image, same marker pen font ) as you've done so well for other plugins. I think what @alecharp is saying is there are some issues with the legacy SVG, specifically under Linux that would need to be addressed, preferably as part of this PR.. But if proposing to move a skeuomorphic / "material theme" design, the plugin purpose should be somewhat representative in the iconography, something that often seems to get lost in translation, especially with computing artifacts. A "paper" icon is not suggestive of anything and potentially confusing. That's where my proposal [ gear + lock + paper ] aggregate icon comes in. It would be more representative than the existing "C - F - G " marker pen icon, if the Plugin owner/maintainer (@olamy / @alecharp ) are amenable to change. This would be a separate PR. |
52ce416
to
45b8db8
Compare
45b8db8
to
6bca63e
Compare
@jenkinsci/config-file-provider-plugin-developers any chance we could get this merged and released please? I reverted the initial concerns from alecharp for the time being so that this PR now does address the sunset icons for removal only. |
ping @jenkinsci/config-file-provider-plugin-developers |
Hello @alecharp, can we have a look together and discuss it ? |
That would be much appreciated <3 |
@NotMyFault Reviewed with @jmMeessen and it's good. I'm merging this. Thank you for the contribution. Note: please try not to force push on PR when someone already review its content. It removes all comments and all, so we lose the "this has been fixed" from previous review. |
Oops, didn't think about that, sorry! Hope that didn't cause too much inconveniences. |
or enabling CD 😄 |
💯 |
We are going to finalize this icon proposed above into an SVG image. |
@Riliane, do you intend to proceed with a revised "C-F-G" (SVG) icon or per the skeuomorphic proposal ( my preference 😄 ) ? should the skeuomorphic design align with the new fontawesome/ionicon representations? |
A Material based icon I consider the better choice and actually we have now considered existing Material + community-made icons, and are considering something like this - https://materialdesignicons.com/icon/file-cog-outline |
Preparation for core sunsetting dated icons: jenkinsci/jenkins#5778