Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.jenkins-ci.main:maven-plugin from 3.22 to 3.23 #288

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 7, 2023

Bumps org.jenkins-ci.main:maven-plugin from 3.22 to 3.23.

Release notes

Sourced from org.jenkins-ci.main:maven-plugin's releases.

Maven Plugin 3.23

👻 Maintenance

Commits
  • f346250 [maven-release-plugin] prepare release maven-plugin-3.23
  • 17ebe89 Refresh plugin for June 2023 (#313)
  • 77bbf5e [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies java Pull requests that update Java code labels Aug 7, 2023
@olamy
Copy link
Member

olamy commented Sep 16, 2023

@dependabot rebase

Bumps [org.jenkins-ci.main:maven-plugin](https://github.com/jenkinsci/maven-plugin) from 3.22 to 3.23.
- [Release notes](https://github.com/jenkinsci/maven-plugin/releases)
- [Commits](jenkinsci/maven-plugin@maven-plugin-3.22...maven-plugin-3.23)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.main:maven-plugin
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/master/org.jenkins-ci.main-maven-plugin-3.23 branch from bb1f781 to df2b383 Compare September 16, 2023 09:34
@dependabot dependabot bot requested a review from a team as a code owner September 16, 2023 09:34
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Sep 16, 2023

If I remember correctly, there are complications with plugin dependencies on the maven plugin that are simplified if the maven dependency is managed by the plugin bill of materials. The maven plugin dependency is managed in plugin bill of materials versions 2.387.x and newer. @olamy would you be willing to consider requiring Jenkins 2.387.x or newer for this plugin?

I've submitted a pull request proposing 2.387.3 as new minimum Jenkins version for the plugin. You're welcome to close pull request 293 if you would rather not increase the minimum Jenkins version in order to stop managing the version of the maven plugin in the test dependency.

@olamy
Copy link
Member

olamy commented Sep 17, 2023

If I remember correctly, there are complications with plugin dependencies on the maven plugin that are simplified if the maven dependency is managed by the plugin bill of materials. The maven plugin dependency is managed in plugin bill of materials versions 2.387.x and newer. @olamy would you be willing to consider requiring Jenkins 2.387.x or newer for this plugin?

Yes sounds good to me. In fact I'm a bit surprised it's not already the case :)

I've submitted a pull request proposing 2.387.3 as new minimum Jenkins version for the plugin. You're welcome to close pull request 293 if you would rather not increase the minimum Jenkins version in order to stop managing the version of the maven plugin in the test dependency.

@MarkEWaite
Copy link
Contributor

This can be closed. The update to require Jenkins 2.387.3 or newer has also moved this version management responsibility to the plugin bill of materials.

@alecharp alecharp closed this Sep 18, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 18, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/master/org.jenkins-ci.main-maven-plugin-3.23 branch September 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants