Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73027] Allow users with Overall/Manage permission to configure config files #330

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

amuniz
Copy link
Member

@amuniz amuniz commented Apr 17, 2024

See JENKINS-73027.

Testing done

Submitter checklist

@amuniz amuniz requested a review from a team as a code owner April 17, 2024 11:14
@alecharp
Copy link
Member

Looks good to me.
However, the jep is still in draft. Is this just a proof of concept?

@amuniz
Copy link
Member Author

amuniz commented Apr 18, 2024

the jep is still in draft

I'm not sure why it's in draft, many plugins were adapted to use the Manage permission a long time ago, some of those plugins are the most installed ones (like git-plugin or workflow-api, for example). Also, CloudBees has been using this permission on private plugins for years. So IMO the "proof of concept" period is long past, the feature has been implemented in many plugins and there are no reports of broken or failing things.

Is this just a proof of concept?

No.

@alecharp alecharp enabled auto-merge April 18, 2024 12:50
@alecharp
Copy link
Member

I see. JEP might need to be updated and probably shouldn't require beta anymore.
But that's a different story.

Thank you for this pull request.

@alecharp alecharp added this pull request to the merge queue Apr 18, 2024
Merged via the queue into jenkinsci:master with commit ce072ff Apr 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants