Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core version of commons-digester2 and replace with digester3 #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

car-roll
Copy link

Upgrade to commons-digester3. Follow up of jenkinsci/jenkins#5320

ping @MadsNielsen

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link

@MRamonLeon MRamonLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changing what Adrien suggested

Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what @alecharp commented on.

Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
@car-roll car-roll requested review from rsandell and alecharp May 3, 2021 16:22
@@ -63,7 +63,7 @@

<repository>
<id>jgit-repository</id>
<url>http://download.eclipse.org/jgit/maven</url>
<url>https://repo.eclipse.org/content/repositories/jgit-releases/</url>
Copy link
Member

@jtnord jtnord May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? unclear to me as this is should be proxied by https://repo.jenkins-ci.org/public/ (there is indeed a jgit repo) - but maybe the config in https://repo.jenkins-ci.org/jgit/ is pointing to the now defunct location?) (//cc @daniel-beck )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants