-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove core version of commons-digester2 and replace with digester3 #3
base: master
Are you sure you want to change the base?
Conversation
0db556b
to
4e2619a
Compare
src/main/java/net/praqma/jenkins/configrotator/scm/ConfigRotatorChangeLogParser.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after changing what Adrien suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what @alecharp commented on.
Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
@@ -63,7 +63,7 @@ | |||
|
|||
<repository> | |||
<id>jgit-repository</id> | |||
<url>http://download.eclipse.org/jgit/maven</url> | |||
<url>https://repo.eclipse.org/content/repositories/jgit-releases/</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed? unclear to me as this is should be proxied by https://repo.jenkins-ci.org/public/ (there is indeed a jgit repo) - but maybe the config in https://repo.jenkins-ci.org/jgit/ is pointing to the now defunct location?) (//cc @daniel-beck )
Upgrade to commons-digester3. Follow up of jenkinsci/jenkins#5320
ping @MadsNielsen