Depend on commons-text-api #1979
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
============================================
+ Coverage 80.81% 80.89% +0.07%
+ Complexity 838 837 -1
============================================
Files 71 71
Lines 2471 2465 -6
Branches 346 346
============================================
- Hits 1997 1994 -3
+ Misses 365 362 -3
Partials 109 109
|
plugin/pom.xml
Outdated
| @@ -86,6 +86,19 @@ | |||
| <groupId>org.apache.commons</groupId> | |||
| <artifactId>commons-text</artifactId> | |||
| <version>1.9</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
I wonder if it’s better that commons text is packaged as one too as that’s where commons lang comes from in a lot of plugins
There was a problem hiding this comment.
Makes sense to me. I've seen it as a dependency on other plugins.
Is there a quick way to tell how many plugins bundle commons-text today?
There was a problem hiding this comment.
@sghill basic code search: https://github.com/search?q=org%3Ajenkinsci+commons-text+filename%3Apom&type=code
if you have cs.github.com you can be more exact: https://cs.github.com/?scopeName=All+repos&scope=&q=%3CartifactId%3Ecommons-text%3C%2FartifactId%3E+owner%3Ajenkinsci
If you do not have access to cs.github.com here you go:
There was a problem hiding this comment.
Thanks @jetersen! The number is potentially quite a bit higher, because it could be brought in transitively I think?
20 sounds like a good reason for an api plugin, but I'm not sure if there are already rules for when to introduce an api plugin.
There was a problem hiding this comment.
normally 2 or more is enough to justify an api plugin.
There was a problem hiding this comment.
@sghill I'd suggest keeping changelog out of the README and use GitHub releases as they integrate with Jenkins Plugin site.
See: https://plugins.jenkins.io/configuration-as-code/#releases
There was a problem hiding this comment.
This may also be helpful: https://www.jenkins.io/doc/developer/publishing/releasing-cd/
There was a problem hiding this comment.
Thanks very much for the help (and patience!) @jetersen. This is now published and I have updated this PR to rely on commons-text-api, which in turn relies on commons-lang3-api.
Separately, I noticed commons-lang3-api has a nonstandard versioning scheme (3.12.0.0, rather than 3.12.0-v{count}.{sha}). Is that something we want to fix before rolling this out, or is it fine?
sghill
changed the title
jetersen
changed the title
|
See jenkinsci/commons-lang3-api-plugin#18. If @timja @jetersen perhaps this change could be reverted on a temporary basis to address the emergency? |
Hi,
I have introduced
commons-text-api, which in turn depends oncommons-lang3-api. This PR replaces the dependency on the commons-text jar with the plugin, and now both jars are absent from the hpi:Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.