Migrate tests to JUnit5 #2634
Draft
Migrate tests to JUnit5 #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate annotations * Migrate assertions * Cleanup assertions * Remove public visibility of test classes and methods
|
Seems like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate tests to JUnit5. Changes include:
I did not migrate tests that explicitly test behavior of the JUnit4 rules provided by the plugin.
There are no changes to the public classes and utilities delivered by this plugin (besides https://github.com/strangelookingnerd/configuration-as-code-plugin/blob/c0e1e348f7d955560eb2219840a5cbb920245ff0/test-harness/src/main/java/io/jenkins/plugins/casc/misc/Util.java#L205-L243).
Some tests can not (yet) be migrated. Most of which use
JenkinsConfiguredWithReadmeRule. While that could also be migrated to a JUnit5 Extension likeJenkinsConfiguredWithCodeExtension, it seems like no other project is using that rule. Therefore I'm honestly not sure if it is worth the effort.Your checklist for this pull request