Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove regression in TODO in automated changelog #18

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Remove regression in TODO in automated changelog #18

merged 1 commit into from
Sep 6, 2021

Conversation

timja
Copy link
Member

@timja timja commented Sep 6, 2021

Needs to be in the changelog directly for automated ones I don't think we want any TODOs appearing

MarkEWaite
MarkEWaite approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only deletes the text in the case where it is "regression in TODO", not "regression in ". Seems reasonable to me.

@timja timja merged commit 1ee801f into master Sep 6, 2021
@timja timja deleted the timja-patch-1 branch September 6, 2021 13:57
@MarkEWaite MarkEWaite added the bug Something isn't working label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timja @MarkEWaite